Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(.github/actions/pnpm-setup-node): remove version field in with of pnpm/action-setup #1363

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore(.github/actions/pnpm-setup-node): remove version field in with of pnpm/action-setup #1363

merged 1 commit into from
Nov 20, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Nov 19, 2024

Overview

removed the version specified in the with field of pnpm/action-setup. when the pnpm version is already defined in the packageManager field of package.json, pnpm/action-setup can automatically recognize and use it. duplicating the version setting adds unnecessary complexity and increases maintenance overhead without added benefit.

by relying on the version specified in packageManager, this change simplifies the configuration and ensures consistency.

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@sukvvon sukvvon requested a review from manudeli as a code owner November 19, 2024 11:36
@coauthors Coauthors
Copy link

coauthors bot commented Nov 19, 2024 •
edited
Loading

People can be co-author:

Candidate Reasons Count Add this as commit message
@sukvvon #1363 1 Co-authored-by: sukvvon <[email protected]>
@codecov-commenter #1363 (comment) 1 Co-authored-by: codecov-commenter <[email protected]>
@manudeli #1363 (review) 1 Co-authored-by: manudeli <[email protected]>

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 841b6f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:39am
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:39am
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:39am

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024

@sukvvon is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (fbb937b) to head (841b6f3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1363   +/-   ##
=======================================
  Coverage   71.86%   71.86%           
=======================================
  Files          67       67           
  Lines         583      583           
  Branches      129      129           
=======================================
  Hits          419      419           
  Misses        151      151           
  Partials       13       13
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 100.00% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 72.86% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/codemods 41.97% <ø> (ø)
---- 🚨 Try these New Features:

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #1363 will create unknown performance changes

Comparing sukvvon:chore/remove-pnpm-action-setup-version (841b6f3) with main (fbb937b)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

manudeli
manudeli approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@manudeli manudeli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@manudeli manudeli merged commit 2d4e68f into toss:main Nov 20, 2024
16 checks passed
@sukvvon sukvvon deleted the chore/remove-pnpm-action-setup-version branch November 20, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudeli manudeli manudeli approved these changes

Assignees

@sukvvon sukvvon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sukvvon @codecov-commenter @manudeli